diff --git a/lua/app/userdata/hero/hero_entity.lua b/lua/app/userdata/hero/hero_entity.lua
index db119246..1bdfaa6e 100644
--- a/lua/app/userdata/hero/hero_entity.lua
+++ b/lua/app/userdata/hero/hero_entity.lua
@@ -48,14 +48,20 @@ function HeroEntity:getAllAttr()
 	if self.allAttr == nil then
 		self:initAttr()
 	end
+	local needUpdate = false
+
 	if self.baseAttrDirty == true then
+		needUpdate = true
 		self.baseAttrDirty = false
 		self:updateBaseAttr()
-		self:updateTotalAttr()
 	end
 	if self.equipAttrDirty == true then
+		needUpdate = true
 		self.equipAttrDirty = false
 		self:updateEquipAttr()
+	end
+
+	if needUpdate then
 		self:updateTotalAttr()
 	end
 	return self.allAttr